Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning if texture is not POT and mipmap is enabled (WebGL 1) #251

Closed
yaustar opened this issue Dec 11, 2020 · 3 comments
Closed
Assignees
Labels
docs Improvements or additions to documentation

Comments

@yaustar
Copy link
Contributor

yaustar commented Dec 11, 2020

WebGL 1 doesn't support mipmaps on textures that are not POT. We should show a warning in the inspector to make it clear to the user that this could be a concern:

Eg

"Only WebGL2 supports mipmap generation on non power of two textures in width and height. (E.g. 256 x 256, 512 x 1024). See https://caniuse.com/webgl2 to see current browser support. Expect browsers that only support WebGL1 to render differently."

image

@yaustar yaustar added docs Improvements or additions to documentation enhancement labels Dec 11, 2020
@yaustar
Copy link
Contributor Author

yaustar commented Mar 12, 2021

Warning should also describe symptoms of what would happen if they aren't POT.

Related forum post: https://forum.playcanvas.com/t/solved-particle-system-textures-appear-pixelated/18787/4

@Maksims
Copy link

Maksims commented Mar 13, 2021

That is why defaults in assets settings to use PoT - is still important today. And should be disabled only by a developer/artist who is aware of consequences.

@yaustar
Copy link
Contributor Author

yaustar commented Jul 14, 2021

@yaustar yaustar closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants