Can't remove folders in asset panel

[leonidaspir]

This has happened to a forum user, and I was able to reproduce at that same instance. After a couple of minutes the issue was resolved and the folder was deleted.

Steps to Reproduce

1. Create a new folder on any Playcanvas project
2. Right click on it and select delete
3. Pressing delete on the new modal didn't remove the folder.

Forum thread: https://forum.playcanvas.com/t/editor-down-cant-connect/11968

[AlbertoMalavasi]

Not only folders, but any file contained in any folder..

https://forum-files-playcanvas-com.s3.dualstack.eu-west-1.amazonaws.com/original/2X/1/18833df9bdf0d4100d3dff792a5829e62e7e2194.mp4

[willeastcott]

Fixed. Apologies for the inconvenience. A server needed a restart.

[WangNianyi2001]

Fixed. Apologies for the inconvenience. A server needed a restart.

It now happens again :-(

[yaustar]

@WangNianyi2001 I've just tried now and I can't reproduce the issue. Can you try refresh your page/browser if you haven't tried already.

If that doesn't work, is it one particular folder that cannot be deleted? Or any folder?

[WangNianyi2001]

@yaustar sry I made a silly mistake--I clicked on the orange cancel button instead of the gray delete button (facepalm)

[Maksims]

The orange button is definitely misleading.
Especially when using Delete > Enter keyboard combination, it does not work.

[willeastcott]

cc @rawkas

[vkalpias]

I think the logic behind this design is that because it's a delete which you can't undo, it highlights the Cancel button because if you are going to click on a button accidentally it'd better be the Cancel instead of the Delete.

[vkalpias]

The orange button is definitely misleading.
Especially when using Delete > Enter keyboard combination, it does not work.

That is by design as we had people accidentally deleting the wrong thing. So we made Delete a little more difficult to require conscious effort.

[willeastcott]

I think if we had a 'trash' that would allow you to undo an asset delete, it would solve this problem.

[Maksims]

The orange button is definitely misleading.
Especially when using Delete > Enter keyboard combination, it does not work.

That is by design as we had people accidentally deleting the wrong thing. So we made Delete a little more difficult to require conscious effort.

By clicking "wrong" button, it's ok, then probably should be highlighted equal, or at least the delete button to be actually red, so the user sees it is an important button.

But please, bring back "enter" hotkey, as hitting Enter after Delete button - is definitely a conscious action.

I think if we had a 'trash' that would allow you to undo an asset delete, it would solve this problem.

That definitely would help. But it sounds complex:

1. Trashed assets should not be accessible by runtime (not added to app.assets).
2. Trashed assets should not be exported to the build.
3. Trashed assets should not be referencable by asset pickers.
4. Trashed assets should be respected by "unused" Editor system.
5. Moving to the trash and restoring from trash, for runtime should act as "delete/create" assets.
6. What about selecting trashed assets in Inspector, should it still be ok to edit them, etc?

[yaustar]

By clicking "wrong" button, it's ok, then probably should be highlighted equal, or at least the delete button to be actually red, so the user sees it is an important button.

It's a tough as both options make sense.

But please, bring back "enter" hotkey, as hitting Enter after Delete button - is definitely a conscious action.

IIRC, the typical pattern is to have 'cancel' as the preselected option, and the user can press tab to select the next option.

[Maksims]

I wouldn't say "typical" based on a single platform.

[yaustar]

Hm, I actually thought Windows defaulted to no. Bear in mind I'm thinking of other programs etc that I've used which annoyingly I now can't find an example of 😅

Unity just deletes files without a warning which is surprising.

Just tried Google Drive and it matches what Max is saying about the delete action being preselected for enter

[WangNianyi2001]

Maybe there would be a prefferable mixed solution: highlight the "delete" button while setting the default keyboard focus to "cancel". This avoids visual confusion & grant keyboard users access to actually performing the deletion.

BTW I think maybe we should create a new issue or forum post, since this one is already closed.

[Maksims]

Maybe there would be a prefferable mixed solution: highlight the "delete" button while setting the default keyboard focus to "cancel". This avoids visual confusion & grant keyboard users access to actually performing the deletion.

I believe you've meant the opposite:
Highlights "Cancel", but "Enter" keyboard would lead to deletion.

This, not a great UX, for sure. As highlights will mislead of what is the keyboard "focused", although Editor does not have "button focus" UX pattern.

Trash - is complex, and not a quick solution.
Making "Delete" button Red (not orange), would make it more "apparent", that this is an important button.
Enter should be "Delete" not "Cancel", as often deleting stuff, I'm personally am frustrated with a need to use mouse.