Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser lag when folder with many assets is open #746

Open
Sidelity opened this issue Apr 25, 2022 · 2 comments
Open

Browser lag when folder with many assets is open #746

Sidelity opened this issue Apr 25, 2022 · 2 comments
Labels
area: editor interface bug Something isn't working

Comments

@Sidelity
Copy link

Description

When entering a folder with hundreds of assets that have thumbnails, like materials, the browser starts lagging. The problem is exacerbated when running a workstation CPU that usually has slower but more cores (compared to a consumer CPU).

Related forum thread: https://forum.playcanvas.com/t/browser-lag-when-folder-with-many-assets-is-open
Test project: https://playcanvas.com/project/916789/overview/asset-thumbnails-performance

Steps to reproduce:

  1. Open Test project
  2. Enter 512 folder
  3. Scroll to the bottom (to generate thumbnails)
  4. Rotate/move viewport camera to see performance problem
@yaustar yaustar added the bug Something isn't working label Apr 25, 2022
@yak32
Copy link

yak32 commented Jun 24, 2022

Some kind of Chrome rendering issue - I've tested the same project in Safari and it was fine. Safari has another issue though - first time the project loaded, it hangs when I clicked on folder with 128, 256 or 512 thumbnails. Assets are rendered with PCUI library, which simply adds thumbnails to the DOM. Profiling in Chrome reveals that 95% is spent in System, so it's not a JS issue.

@yaustar
Copy link
Contributor

yaustar commented Aug 16, 2022

Potentially related to #862

Description
When opening a folder in the assets panel, which contains many items, performance of the editor degrades drastically. Same behaviour also applies for the scene hierarchy panel.

This is probably not a "bug" with the editor but has more to do with how pcui renders those elements.
I think a solution which is applied often in this case, is to not render the items which are not in view (hidden because of scroll bar).

Steps to Reproduce

  • Create a folder with many items inside
  • Open the folder
  • Performance is bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: editor interface bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants