Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings don't seem to work in Chromium #2

Closed
ghost opened this issue Jun 5, 2014 · 19 comments
Closed

Keybindings don't seem to work in Chromium #2

ghost opened this issue Jun 5, 2014 · 19 comments

Comments

@ghost
Copy link

ghost commented Jun 5, 2014

I am unable perform keyboard shortcuts (ie. alt+middle-click to pan) in the IDE, or navigate via the WASD keys in an FPS template project. I am using Chromium version 37.0.2030.0 (Developer Build 274814).

@daredevildave
Copy link
Contributor

Which OS? Chromium on Mac seems to be fine.

@willeastcott
Copy link
Contributor

I'm guessing this is Chrome OS. On that OS, ALT+LMB has a system level 'special meaning': it simulates a right mouse button click. This is a bug in Designer.

As for WASD not working in the FPS Starter Kit, I haven't been able to repro that. I'm on:

Version: 35.0.1916.116
Platform: 571.61.0 (Official Build) stable-channel peach_pi
Firmware Google_Peach_Pi.4482.94.0

This is a brand new Samsung Chromebook (ARM based model that has just been released).

@ghost
Copy link
Author

ghost commented Jun 5, 2014

Hey all,

Thanks for the reply. I'm running on Gentoo Linux. I'd be happy to provide
any other info you need.

Thanks :)
On Jun 5, 2014 6:05 AM, "willeastcott" notifications@github.com wrote:

I'm guessing this is Chrome OS. On that OS, ALT+LMB has a system level
'special meaning': it simulates a right mouse button click. This is a bug.

As for WASD not working in the FPS Starter Kit, I haven't been able to
repro that. I'm on:

Version: 35.0.1916.116
Platform: 571.61.0 (Official Build) stable-channel peach_pi
Firmware Google_Peach_Pi.4482.94.0

This is a brand new Samsung Chromebook (ARM based model that has just been
released).


Reply to this email directly or view it on GitHub
#2 (comment).

@ghost
Copy link
Author

ghost commented Jun 5, 2014

Okay, tried a couple more things and it appears that in the IDE the 'A' key works and most other keybindings work; but 'ALT' doesn't seem to for me. I'm guessing my window manager (OpenBox) is eating my 'ALT' strokes. I'll check out the FPS gameplay again to see if the WASD keys are being emitted. I'll also add event handlers for keyup and see what keycodes are being bubbled. I'll post the results back here.

@ghost
Copy link
Author

ghost commented Jun 5, 2014

18 is the ALT keycode that's being captured by document in the IDE.

@ghost
Copy link
Author

ghost commented Jun 5, 2014

87 = W
65 = A
83 = S
68 = D

Are the keycodes being captured by document in the IDE.

@ghost
Copy link
Author

ghost commented Jun 5, 2014

The aforementioned keycodes are also being captured by document in the FPS test as well.

@ghost ghost closed this as completed Jun 5, 2014
@ghost ghost reopened this Jun 5, 2014
@ghost
Copy link
Author

ghost commented Jun 5, 2014

Wroops, clicked the wrong button.

@willeastcott
Copy link
Contributor

Yes, those are the standard key codes for those keys that should always be returned. See here: http://www.cambiaresearch.com/articles/15/javascript-char-codes-key-codes

@Maksims Can you test Designer on your Linux rig this evening? And create a project with the FPS starter kit and see if WASD works?

@Maksims
Copy link
Contributor

Maksims commented Jun 5, 2014

@willeastcott just verified on Version 34.0.1847.116 Ubuntu 12.04 (260972), that keyboard input works as WASD in FPS example on playcanvas platform.
BUT, the example in engine folder which is accessible here: http://playcanvas.github.io/#camera/first_person/index.html
Does not do WASD in first place, as it is arrows there. So if arrows do work in that example (fps one), then we just need to add WASD as more common fly/fps movement controls. (doh, who did arrows? no one uses arrows nowadays :D )
As well verified that Russian layout keyboard does not affects keyboard input and it still works fine.

@willeastcott
Copy link
Contributor

@Maksims And presumably ALT+LMB in Designer to orbit works OK?

@guywithcrookedface Can you confirm:
'WASD not working' is in the FPS Starter Kit in PlayCanvas Designer, correct? Not this engine demo:
http://playcanvas.github.io/#camera/first_person/index.html
?

@willeastcott
Copy link
Contributor

@guywithcrookedface Also, can you confirm this behaviour is the same in Firefox on your Gentoo machine?

@ghost
Copy link
Author

ghost commented Jun 5, 2014

Sure thing,

I'll download nightly and see if it works; thanks for the quick reply on
this guys =D

On Thu, Jun 5, 2014 at 6:18 PM, willeastcott notifications@github.com
wrote:

@guywithcrookedface https://github.com/guywithcrookedface Also, can you
confirm this behaviour is the same in Firefox on your Gentoo machine?


Reply to this email directly or view it on GitHub
#2 (comment).

@ghost
Copy link
Author

ghost commented Jun 5, 2014

Hrm,

Tried with nightly Firefox and I'm still not seeing movement with the WASD
keys, or the arrow keys in an FPS project. I'll try the IDE and see what
happens there.

On Thu, Jun 5, 2014 at 6:33 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

Sure thing,

I'll download nightly and see if it works; thanks for the quick reply on
this guys =D

On Thu, Jun 5, 2014 at 6:18 PM, willeastcott notifications@github.com
wrote:

@guywithcrookedface https://github.com/guywithcrookedface Also, can
you confirm this behaviour is the same in Firefox on your Gentoo machine?


Reply to this email directly or view it on GitHub
#2 (comment).

@willeastcott
Copy link
Contributor

Ah. I see the problem. Can you go to the project settings and check the box that says 'Enable 3D Physics'? This is a result of a bug we had a couple of days ago where forking a project would not copy the project settings. This is now fixed but any projects that were forked when the bug was in existence will be affected.

@ghost
Copy link
Author

ghost commented Jun 5, 2014

The IDE keybindings seem to work fine. Except ALT+* keybindings, which
might be due to my window manager. When I try left alt and middle click my
window manager grabs them first so they never make it to the browser;
that's something I can work with though.

If there's anything else I can do to help here lemme know :)

On Thu, Jun 5, 2014 at 6:36 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

Hrm,

Tried with nightly Firefox and I'm still not seeing movement with the WASD
keys, or the arrow keys in an FPS project. I'll try the IDE and see what
happens there.

On Thu, Jun 5, 2014 at 6:33 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

Sure thing,

I'll download nightly and see if it works; thanks for the quick reply on
this guys =D

On Thu, Jun 5, 2014 at 6:18 PM, willeastcott notifications@github.com
wrote:

@guywithcrookedface https://github.com/guywithcrookedface Also, can
you confirm this behaviour is the same in Firefox on your Gentoo machine?


Reply to this email directly or view it on GitHub
#2 (comment).

@ghost
Copy link
Author

ghost commented Jun 5, 2014

Sure thing,

I'll tick that box and try again; thanks Will.

On Thu, Jun 5, 2014 at 6:40 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

The IDE keybindings seem to work fine. Except ALT+* keybindings, which
might be due to my window manager. When I try left alt and middle click my
window manager grabs them first so they never make it to the browser;
that's something I can work with though.

If there's anything else I can do to help here lemme know :)

On Thu, Jun 5, 2014 at 6:36 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

Hrm,

Tried with nightly Firefox and I'm still not seeing movement with the
WASD keys, or the arrow keys in an FPS project. I'll try the IDE and see
what happens there.

On Thu, Jun 5, 2014 at 6:33 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

Sure thing,

I'll download nightly and see if it works; thanks for the quick reply on
this guys =D

On Thu, Jun 5, 2014 at 6:18 PM, willeastcott notifications@github.com
wrote:

@guywithcrookedface https://github.com/guywithcrookedface Also, can
you confirm this behaviour is the same in Firefox on your Gentoo machine?


Reply to this email directly or view it on GitHub
#2 (comment).

@ghost
Copy link
Author

ghost commented Jun 5, 2014

w000t, that fixed it =D

Thanks to all!

On Thu, Jun 5, 2014 at 6:41 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

Sure thing,

I'll tick that box and try again; thanks Will.

On Thu, Jun 5, 2014 at 6:40 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

The IDE keybindings seem to work fine. Except ALT+* keybindings, which
might be due to my window manager. When I try left alt and middle click my
window manager grabs them first so they never make it to the browser;
that's something I can work with though.

If there's anything else I can do to help here lemme know :)

On Thu, Jun 5, 2014 at 6:36 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

Hrm,

Tried with nightly Firefox and I'm still not seeing movement with the
WASD keys, or the arrow keys in an FPS project. I'll try the IDE and see
what happens there.

On Thu, Jun 5, 2014 at 6:33 PM, Christopher Dale <
guy.with.crooked.face@gmail.com> wrote:

Sure thing,

I'll download nightly and see if it works; thanks for the quick reply
on this guys =D

On Thu, Jun 5, 2014 at 6:18 PM, willeastcott notifications@github.com
wrote:

@guywithcrookedface https://github.com/guywithcrookedface Also, can
you confirm this behaviour is the same in Firefox on your Gentoo machine?


Reply to this email directly or view it on GitHub
#2 (comment).

@Maksims
Copy link
Contributor

Maksims commented Jun 6, 2014

That was my bug! :D
Now it is fixed indeed. There might be small number of people made projects during period of bugs wildness, which will result of physics library not being included into list of scripts of a pack.
But hopefully all fine now.

@Maksims Maksims closed this as completed Jun 6, 2014
Maksims pushed a commit that referenced this issue Oct 16, 2014
Maksims pushed a commit that referenced this issue Jun 30, 2016
Update scene_phongmaterial.js
raytranuk added a commit that referenced this issue Dec 21, 2020
1) Light type replaced with light source shape property.
2) Disk and Sphere light source shapes added.**
3) Light source shapes made to work with existing punctual light types and features i.e shadows, culling, cookies, falloff range etc.***
4) All light source shapes made to work with all light types.****
5) "point" light renamed to "omni" light, and "point" aliased to "omni" on light creation for backwards compatibility.

** Sphere light source shape diffuse lighting can be further improved - probably relatively cheaply with wrap lighting.
*** Punctual dynamic shadows are only an approximation - area light shadows should be implemented for higher quality.
**** Directional area light specular can be further improved - currently approximated with a shape on the far clip plane.
MAG-AdrianMeredith referenced this issue in magnopus/playcanvas-engine Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants