Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader compilation issue on devices without extStandardDerivatives #4772

Closed
mvaligursky opened this issue Oct 20, 2022 · 2 comments · Fixed by #4798
Closed

Shader compilation issue on devices without extStandardDerivatives #4772

mvaligursky opened this issue Oct 20, 2022 · 2 comments · Fixed by #4798
Assignees
Labels
area: graphics Graphics related issue bug

Comments

@mvaligursky
Copy link
Contributor

Repro:

  • disable extStandardDerivatives in WebglGraphicsDevice by commenting out line //this.extStandardDerivatives = true;
  • run engine example: render-asset

Screenshot 2022-10-20 at 12 47 59

The problem is missing varying vObjectSpaceUpW; in the fragment shader.
builtinVaryings in lit-shader.js has that in the list, but those are only added to vertex shader, but not to fragment.

@GSterbrant
Copy link
Contributor

Do you have an example device to test this on?

@mvaligursky
Copy link
Contributor Author

I do not, I only simulated one by disabling the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants