Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling model and moving the camera causes error in clustered lighting renderer with shadows #4951

Closed
yaustar opened this issue Jan 5, 2023 · 0 comments · Fixed by #4958
Assignees
Labels
area: graphics Graphics related issue bug

Comments

@yaustar
Copy link
Contributor

yaustar commented Jan 5, 2023

Thread: https://forum.playcanvas.com/t/solved-cannot-read-properties-of-null-reading-device/29128

Honestly not sure how to title this one

Project: https://playcanvas.com/project/1025265

Click on the button 'Click here'. This disables the Box and moves the camera. Erro:

mesh-instance.js:753 Uncaught TypeError: Cannot read properties of null (reading 'device')
    at MeshInstance.updatePassShader (mesh-instance.js:753:71)
    at ShadowRenderer.submitCasters (shadow-renderer.js:519:30)
    at ShadowRenderer.render (shadow-renderer.js:582:22)
    at ForwardRenderer.renderShadows (forward-renderer.js:1122:34)
    at RenderPass.execute (forward-renderer.js:1964:22)
    at RenderPass.render (render-pass.js:215:14)
    at FrameGraph.render (frame-graph.js:127:29)
    at Application.renderComposition (app-base.js:1240:25)
    at Application.render (app-base.js:1228:14)
    at app-base.js:2201:29

Findings

  • Removing the batch group on ‘Box001-test’ stops the error from triggering
  • Changing all the Omni Lights under ‘Delete any of the lights and the bug stops happening’ to Shadow update mode ‘always’ stops the error
  • Deleting any of the Omni Lights stops the issue from happening
  • Deleting ‘Delete this and all hell breaks lose’ causes the the render to get stuck in an error loop (see #4950)

Disabling clustered lighting also avoids the issue.

@yaustar yaustar added the area: graphics Graphics related issue label Jan 5, 2023
@yaustar yaustar added the bug label Jan 5, 2023
@yaustar yaustar changed the title Disabling model and moving the camera causes error in clustered lighting renderer Disabling model and moving the camera causes error in clustered lighting renderer with shadows Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants