Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ministats doesn't appear in half the examples #5082

Closed
slimbuck opened this issue Feb 20, 2023 · 1 comment · Fixed by #5156
Closed

Ministats doesn't appear in half the examples #5082

slimbuck opened this issue Feb 20, 2023 · 1 comment · Fixed by #5156

Comments

@slimbuck
Copy link
Member

Ministats doesn't work on around half the engine examples.

@mvaligursky
Copy link
Contributor

mvaligursky commented Feb 21, 2023

Well spotted. It turns out mini-stats are missing in examples that use createGraphicsDevice, which is async, and both the device and the app are undefined at the beginning. When the example starts, the setupApp is then skipped.

if (pc.app && pc.app.graphicsDevice.canvas) {
setupApplication(pc.app);
}

@ellthompson - any thoughts on how this can be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants