Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate running engine examples in WebGPU mode using Safari #6088

Closed
mvaligursky opened this issue Feb 26, 2024 · 6 comments
Closed

Investigate running engine examples in WebGPU mode using Safari #6088

mvaligursky opened this issue Feb 26, 2024 · 6 comments
Assignees
Labels
area: graphics Graphics related issue

Comments

@mvaligursky
Copy link
Contributor

Safari now has a behind flag version of the WebGPU in tech preview: https://twitter.com/quicksave2k/status/1737758115720769708

I tested this with Safari Tech Preview Release 189 (Safari 17.4, WebKit 19619.1.3.2)

When running local build of the examples, for example shapes, I get validation errors with no reasons listed:

Screenshot 2024-02-26 at 12 29 20

Interestingly, when I disable our validation (commend out inside of functions in WebgpuDebug class, the browser does not log out any validation issues, which it should. Do they have some validation API issues?

The end result is, that in neither case, the examples work. We get different clear color in few examples, so it seems the clear color works in some cases, but nothing else gets rendered.

Often we also get
Screenshot 2024-02-26 at 12 28 44

@mvaligursky mvaligursky self-assigned this Feb 26, 2024
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Feb 26, 2024
@mvaligursky
Copy link
Contributor Author

Created a webkit error https://bugs.webkit.org/show_bug.cgi?id=270079

@mwyrzykowski
Copy link

I commented in the webkit report but at least one issue, there appear to be several, is that playcanvas is assuming an alignment of 32 bytes for dynamic offsets, based on the 288 value observed. The specification default is 256 and 288 is not divisible by 256. I filed https://bugs.webkit.org/show_bug.cgi?id=272378 to fix the error message

I locally modified WebKit's alignment to be 32, but I see other errors and continue to investigate.

@mvaligursky
Copy link
Contributor Author

@mwyrzykowski - thanks for the update, much appreciated. I responded on the original webkit ticket.

@willeastcott
Copy link
Contributor

@mvaligursky Can this be closed now? The two logged WebKit issues are now marked as RESOLVED FIXED.

@mvaligursky
Copy link
Contributor Author

I'll close it when the Safari Tech Preview contains fixes I can verify.

@mvaligursky
Copy link
Contributor Author

Confirmed fixed in Safari Tech Preview 194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

No branches or pull requests

3 participants