-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate running engine examples in WebGPU mode using Safari #6088
Comments
Created a webkit error https://bugs.webkit.org/show_bug.cgi?id=270079 |
I commented in the webkit report but at least one issue, there appear to be several, is that playcanvas is assuming an alignment of 32 bytes for dynamic offsets, based on the 288 value observed. The specification default is 256 and 288 is not divisible by 256. I filed https://bugs.webkit.org/show_bug.cgi?id=272378 to fix the error message I locally modified WebKit's alignment to be 32, but I see other errors and continue to investigate. |
@mwyrzykowski - thanks for the update, much appreciated. I responded on the original webkit ticket. |
@mvaligursky Can this be closed now? The two logged WebKit issues are now marked as RESOLVED FIXED. |
I'll close it when the Safari Tech Preview contains fixes I can verify. |
Confirmed fixed in Safari Tech Preview 194 |
Safari now has a behind flag version of the WebGPU in tech preview: https://twitter.com/quicksave2k/status/1737758115720769708
I tested this with Safari Tech Preview Release 189 (Safari 17.4, WebKit 19619.1.3.2)
When running local build of the examples, for example shapes, I get validation errors with no reasons listed:
Interestingly, when I disable our validation (commend out inside of functions in
WebgpuDebug
class, the browser does not log out any validation issues, which it should. Do they have some validation API issues?The end result is, that in neither case, the examples work. We get different clear color in few examples, so it seems the clear color works in some cases, but nothing else gets rendered.
Often we also get
![Screenshot 2024-02-26 at 12 28 44](https://private-user-images.githubusercontent.com/59932779/307787760-017102a6-323a-4778-bb44-c2fa12391beb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNjQ5NTgsIm5iZiI6MTcyMTI2NDY1OCwicGF0aCI6Ii81OTkzMjc3OS8zMDc3ODc3NjAtMDE3MTAyYTYtMzIzYS00Nzc4LWJiNDQtYzJmYTEyMzkxYmViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDAxMDQxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlmMzc1ODZiMzE3ZjBlZTg4ODA5MWM1ZWQ0NWRhZmNiODUzMDc4YmE4MTFhZDU5MjEzNzEzZTJjNjk3NGZlZmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZFakr1_9McovWgUrJvyYXY0mHLjD9I38rwlF-TpNiBA)
The text was updated successfully, but these errors were encountered: