Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.69.0 Install error - Node 16.0 #6152

Closed
1 of 2 tasks
marklundin opened this issue Mar 13, 2024 · 10 comments · Fixed by #6153
Closed
1 of 2 tasks

1.69.0 Install error - Node 16.0 #6152

marklundin opened this issue Mar 13, 2024 · 10 comments · Fixed by #6153
Assignees
Labels

Comments

@marklundin
Copy link
Member

marklundin commented Mar 13, 2024

There is an error in v1.69.0 which prevents the engine being installed using various package managers such as yarn, pnpm or npm.

This has been reported on the forum but it is also affecting some CDN's

ESM.sh v1.69.1
ESM.sh v1.69.0
ESM.sh v1.68.1

Skypack v1.69.1
Skypack v1.69.0
Skypack v1.68.1

This seems to be 2 separate issues.

Update - added 1.69.1

@marklundin
Copy link
Member Author

It looks like playcanvas-extras.mjs is listed as an export, but the file is not included in the build

"import": "./build/playcanvas-extras.mjs",

engine/package.json

Lines 85 to 103 in 607e3a8

"files": [
"build/playcanvas.js",
"build/playcanvas.min.js",
"build/playcanvas.dbg.js",
"build/playcanvas.prf.js",
"build/playcanvas.mjs",
"build/playcanvas.min.mjs",
"build/playcanvas.dbg.mjs",
"build/playcanvas.prf.mjs",
"build/playcanvas.d.ts",
"build/playcanvas-extras.js",
"build/playcanvas-extras/index.js",
"scripts",
"LICENSE",
"package.json",
"README.md",
"README-ja.md",
"README-kr.md",
"README-zh.md"

@marklundin
Copy link
Member Author

Keeping this open, as it be also be related to

"playcanvas": "file:."

@marklundin marklundin reopened this Mar 13, 2024
@Maksims
Copy link
Contributor

Maksims commented Mar 13, 2024

We've had also issues installing 1.69.0, and it was a very obscured error.
1.68.2 - works great.

@mvaligursky
Copy link
Contributor

@Maksims - could you please test to see if your issue is fixed in https://github.com/playcanvas/engine/releases/tag/v1.69.1

@LeXXik
Copy link
Contributor

LeXXik commented Mar 13, 2024

Worked for me using yarn add playcanvas -D:

{
  "name": "test",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "devDependencies": {
    "playcanvas": "^1.69.1"
  }
}

@marklundin
Copy link
Member Author

marklundin commented Mar 13, 2024

Node v16 seems to have an issue resolving the circular dependancy at

"playcanvas": "file:."

v18 an upwards works. Updating description

@marklundin marklundin changed the title 1.69.0 Install error 1.69.0 Install error - Node 16.0 Mar 13, 2024
@MAG-AdrianMeredith
Copy link

version v21.1.0 of node does not work. From my experience having a circular dependency is always a bad idea, whatever it is for could there be a better way? The issue I see is not that it can't find it, its also that its stuck in a infinite loop, it tries to fetch playcanvas, then tries to fetch the playcanvas of the playcanvas etc

@marklundin
Copy link
Member Author

Thanks @MAG-AdrianMeredith we're looking into it. Can you confirm what version of yarn you're using?

@willeastcott
Copy link
Contributor

@marklundin This is now fixed, right?

@marklundin
Copy link
Member Author

Yep, this should now be fixed with #6168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants