-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The viewer linked to glTF Asset Generator is out of date #33
Comments
It seems that it was merged into engines.json, but the viewer doesn't seem to display properly. <iframe src="https://playcanvas.com/viewer/?assetUrl=https://raw.githubusercontent.com/KhronosGroup/glTF-Asset-Generator/master/Output/Positive/Node_Attribute/Node_Attribute_00.gltf&cameraPosition=0,20,-20">
</iframe>
|
I'm not sure where the http protocol is being used (instead of https). In the engines.json, I used https. |
I tried the iframe in jsfiddle and the Babylon.js and three.js viewers seemed to be able to display in the iframe as well. https://jsfiddle.net/cx20/jszda6fu/9/ <!-- Babylon.js -->
<!--
<iframe src="https://sandbox.babylonjs.com/index.html?assetUrl=https://raw.githubusercontent.com/KhronosGroup/glTF-Asset-Generator/master/Output/Positive/Node_Attribute/Node_Attribute_00.gltf&cameraPosition=0,20,-20&kiosk=true"></iframe>
-->
<!-- PlayCanvas.js -->
<iframe src="https://playcanvas.com/viewer/?assetUrl=https://raw.githubusercontent.com/KhronosGroup/glTF-Asset-Generator/master/Output/Positive/Node_Attribute/Node_Attribute_00.gltf&cameraPosition=0,20,-20"></iframe>
<!-- three.js -->
<!--
<iframe src="https://gltf-viewer.donmccurdy.com/#model=https://raw.githubusercontent.com/KhronosGroup/glTF-Asset-Generator/master/Output/Positive/Node_Attribute/Node_Attribute_00.gltf&cameraPosition=0,20,-20&kiosk=true&preset=assetgenerator"></iframe>
--> |
Removing the params from the fiddle URL gives this slightly more useful error: |
yes, we set X-Frame-Options to deny explicitly, to avoid click-jacking attacks, but we can whitelist certain websites. |
we are going to whitelist the site soon. |
It may already be scheduled to be fixed, but I'll report back Issue just in case.
The old playcanvas-gltf viewer is referenced by the Khronos glTF Asset Generator.
https://github.com/KhronosGroup/glTF-Asset-Generator
Perhaps modifying the following configuration file will refer to the new viewer.
https://github.com/bghgary/glTF-Assets-Viewer/blob/master/engines.json
The text was updated successfully, but these errors were encountered: