New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCUI-Graph styles embed PCUI styles #45

Closed

willeastcott opened this issue Mar 20, 2023 · 1 comment · Fixed by #47

Assignees

Labels

bug

Contributor

willeastcott commented Mar 20, 2023 •

edited

Loading

See here:

pcui-graph/src/styles/style.scss

Line 4 in 07d647a

@import '../../node_modules/@playcanvas/pcui/dist/pcui-theme-green.scss';

This feels wrong to me. Shouldn't the application import PCUI and then import PCUI-Graph styles? Some problems:

Currently, the PlayCanvas Editor has two copies of PCUI styles in the compiled CSS.
This forces a user that's using PCUI-Graph to use the PCUI green theme.

willeastcott added the bug label

willeastcott assigned ellthompson

Contributor Author

willeastcott commented Mar 21, 2023

Observation:

With PCUI embedded: 3500 lines of SASS
Without PCUI embedded: 730 lines of SASS

willeastcott mentioned this issue

Remove PCUI styles #47

Merged

willeastcott closed this as completed in #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment