Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate GameServerBuild objects #61

Closed
dgkanatsios opened this issue Nov 9, 2021 · 0 comments · Fixed by #222
Closed

validate GameServerBuild objects #61

dgkanatsios opened this issue Nov 9, 2021 · 0 comments · Fixed by #222
Labels
area/user-experiences Developer experience and suggestions on how to use thundernetes, installation, getting up & running enhancement New feature or request
Milestone

Comments

@dgkanatsios
Copy link
Collaborator

dgkanatsios commented Nov 9, 2021

Currently, the only validation we're doing on GameServerBuild CRD instance is via OpenAPI v3 schema. However, this provides only some naive validation and we should work on validating more things like:

  • standingBy number is <= max
  • when creating a new GameServerBuild, there is NOT an existing GameServerBuild with a different name but the same BuildID. We can check for existing GameServerBuilds with the same BuildID using the metadata-only client as described here
  • validate that hostPort is empty on all containers on the GameServerBuild for ports that are in the portsToExpose array
  • validate that name is included for ports that are on the portsToExpose array
  • validate that all ports on the portsToExpose array exist in the pod container spec

We could use validation webhooks.

@dgkanatsios dgkanatsios added area/user-experiences Developer experience and suggestions on how to use thundernetes, installation, getting up & running enhancement New feature or request labels Nov 9, 2021
@dgkanatsios dgkanatsios added this to the 0.4.0 milestone Apr 5, 2022
@dgkanatsios dgkanatsios changed the title validate GameServerBuild YAML documents validate GameServerBuild objects Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experiences Developer experience and suggestions on how to use thundernetes, installation, getting up & running enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant