Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLA for Play #210

Open
mkurz opened this issue Jan 20, 2022 · 8 comments
Open

CLA for Play #210

mkurz opened this issue Jan 20, 2022 · 8 comments
Projects
Play Community Board

Comments

@mkurz
Copy link
Member

mkurz commented Jan 20, 2022

Can we remove it?
/cc @octonato @ennru
@mkurz mkurz added this to To do in Play Community Board Jan 20, 2022
@mkurz mkurz moved this from To do to In progress in Play Community Board Jan 20, 2022
@mkurz mkurz mentioned this issue Jan 20, 2022
Merged
@octonato
Copy link
Contributor

I think that from Ligthbend perspertive yes, but may be good to have something else for Play.

I will check if there is anything that can be used out there.

@octonato
Copy link
Contributor

I found this: https://github.com/cla-assistant/cla-assistant

There are probably others options.

@octonato
Copy link
Contributor

btw, cla assistant is also used by JHipster: https://cla-assistant.io/jhipster/generator-jhipster?pullRequest=17615

@nafg
Copy link

nafg commented Jun 20, 2022

GitHub has a built in setting that may or may not be helpful

https://github.blog/changelog/2022-06-08-admins-can-require-sign-off-on-web-based-commits/

@ihostage
Copy link
Member

ihostage commented Oct 3, 2022

Typesafe CLA was removed in #243
Now we should think about special CLA for Playframework.

@ihostage ihostage changed the title Retire typesafe-cla-validator CLA for Play Oct 3, 2022
@ihostage ihostage moved this from In progress to To do in Play Community Board Oct 14, 2022
@mkurz
Copy link
Member Author

mkurz commented Oct 19, 2022

https://opensource.guide/

@nafg
Copy link

nafg commented Oct 20, 2022

What about commits that are made after removing the Typesafe one and before implementing a new one?

@mkurz
Copy link
Member Author

mkurz commented Oct 20, 2022

We assume that even without the CLA we are safe because we assume the Apache license already handles everything. A lot of projects don't even use a CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Play Community Board
  
To do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nafg @octonato @mkurz @ihostage