Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 3 support #598

Closed
SethTisue opened this issue Aug 4, 2021 · 10 comments
Closed

Add Scala 3 support #598

SethTisue opened this issue Aug 4, 2021 · 10 comments

Comments

@SethTisue
Copy link
Member

SethTisue commented Aug 4, 2021

would a volunteer like to attempt this? it would be helpful even just to have a failing draft PR that shows where the next roadblock is, and then we could chip away it from there

I published ssl-config and cachecontrol today for Scala 3, so that helps

#590 should be merged before any attempt is made at this

@mkurz
Copy link
Member

mkurz commented Aug 11, 2021

@SethTisue As you probably have noticed, #590 got merged.

@mkurz
Copy link
Member

mkurz commented Aug 15, 2021

@xuwei-k Do you can/want to help?

@xuwei-k
Copy link
Contributor

xuwei-k commented Aug 16, 2021

Could not compile play-ws with Scala 3 due to scala/scala3#12731 😢

type Self <: StandaloneWSRequest { type Self <: StandaloneWSRequest.this.Self }

@wsargent
Copy link
Member

wsargent commented Aug 17, 2021

I thought this was very clever of me at the time (it was mostly actually Adriaan)

@mkurz
Copy link
Member

mkurz commented Aug 30, 2021

@xuwei-k @SethTisue did you see these 2 comments? Replacing F-bounds by intersection types? WDYT? Also see scala/scala3#13133 and scala/scala3#10638 (comment)

If you have an F-bounded type T <: F[T] simply replace it with T. Then everywhere T is used, replace it with T & F[T].

@xuwei-k xuwei-k mentioned this issue Aug 30, 2021
7 tasks
@xuwei-k
Copy link
Contributor

xuwei-k commented Aug 30, 2021

#604

@SethTisue
Copy link
Member Author

@mkurz I'm sorry but I don't know what to think about that, and I don't feel that have time to dig into it. :-/

@mkurz
Copy link
Member

mkurz commented Sep 7, 2021

@SethTisue Currently not so much time as well (coming weeks)...

@ihostage
Copy link
Member

Was implemented in #604 but has some comments #604 (review) from @mkurz

@mkurz mkurz closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants