New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2155] Silent or suppressed errors in unittest PluginCollectionTest#skipsDuplicatePlugins #1221

Closed

flybyray opened this issue Feb 26, 2018 · 1 comment

Labels

defect

Milestone

Contributor

flybyray commented Feb 26, 2018 •

edited

02a75fb in PR #1138
Introduced resource "custom-play.plugins.duplicate" which depends on CorePlugin

15874d0 in PR #1144
Splitted CorePlugin into two Plugins with new Names and Location without modifying custom-play.plugins.duplicate.

Ant task unittest should fail because resource "custom-play.plugins.duplicate" file will not be copied ( see https://github.com/playframework/play1/blob/master/framework/build.xml#L397 ).
Hence the PR #1138 does not really test what it should test.

The text was updated successfully, but these errors were encountered:

flybyray mentioned this issue

[#2155] Silent or suppressed errors in unittest PluginCollectionTest#skipsDuplicatePlugins #1222

Merged

xael-fry added the defect label

xael-fry added this to the 1.5.3 milestone

Member

xael-fry commented Apr 8, 2019

Merged and pushed in master
Thanks

xael-fry closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment