Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for navigating XML with namespaces. #1242

Merged
merged 1 commit into from Aug 23, 2018

Conversation

ludofischer
Copy link
Contributor

Add method overloads that let you generate documents that you can naviagate with XPath while taking XML namespaces into account.
This adds method to get namespace-aware XML documents from strings, files, input streams and request bodies.
Without this, navigating the documents with XPath always returns null if namespaces are taken into account. I’ve added a few tests to demonstrate the issue.

@asolntsev asolntsev self-requested a review June 25, 2018 21:53
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xael-fry Seems to be OK. Can be merged.

@xael-fry xael-fry added this to the 1.5.2 milestone Aug 23, 2018
@xael-fry xael-fry merged commit 8938c6b into playframework:master Aug 23, 2018
@xael-fry
Copy link
Member

xael-fry commented Aug 23, 2018

Merged in master
Thanks @ludovicofischer and @asolntsev

@ludofischer ludofischer deleted the xml-namespace-support branch August 24, 2018 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants