Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1309: Upgrade java mail and commons email #1310

Merged
merged 1 commit into from
Aug 2, 2019
Merged

#1309: Upgrade java mail and commons email #1310

merged 1 commit into from
Aug 2, 2019

Conversation

sant0s
Copy link
Contributor

@sant0s sant0s commented Jul 15, 2019

Fixes issue #1309

@asolntsev
Copy link
Contributor

@sant0s Wait, it's not enough to just update versions in dependencies.yml.
You also need to update actual jar files in https://github.com/playframework/play1/tree/master/framework/lib

@sant0s
Copy link
Contributor Author

sant0s commented Jul 18, 2019 •
edited
Loading

@asolntsev Thanks.

@asolntsev asolntsev self-requested a review July 23, 2019 21:05
asolntsev
asolntsev approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xael-fry Recommended to merge.

@xael-fry xael-fry changed the title 1309: Upgrade java mail and commons email #1309: Upgrade java mail and commons email Aug 2, 2019
@xael-fry xael-fry added this to the 1.5.4 milestone Aug 2, 2019
@xael-fry xael-fry merged commit 1851342 into playframework:master Aug 2, 2019
@xael-fry
Copy link
Member

xael-fry commented Aug 2, 2019

Merge and pushed in master
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asolntsev asolntsev asolntsev approved these changes

@xael-fry xael-fry xael-fry approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sant0s @asolntsev @xael-fry