Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade com.ning:async-http-client to org.asynchttpclient:async-http-client #1426

Open
sp00m opened this issue Sep 1, 2022 · 5 comments
Open

Comments

@sp00m
Copy link
Contributor

sp00m commented Sep 1, 2022

Play v1.7.1 still relies on an old version of AsyncHttpClient: https://github.com/playframework/play1/blob/1.7.1/framework/dependencies.yml#L21.

This library has moved from https://github.com/ning/async-http-client (last commit in 2016) to https://github.com/AsyncHttpClient/async-http-client.

Should we upgrade Play accordingly?

@asolntsev
Copy link
Contributor

@sp00m Yes, sure, it would be great to upgrade Play accordingly.
Can you prepare a pull request?

@asolntsev
Copy link
Contributor

@sp00m Wait, no, we cannot upgrade. This library requires Netty 4.1.60.Final, but Play1 still uses Netty 3.x

@sp00m
Copy link
Contributor Author

sp00m commented Sep 2, 2022

Ouch, good catch! Looks like migrating to Netty 4 is WIP: #1284. That doesn't seem easy though, according to the discussions on that issue :/

@cies
Copy link
Contributor

cies commented Oct 12, 2022

An attempt was also made to upgrade this on RePlay (a Play1 fork): replay-framework/replay#25

It's quite close, but serving static assets is still a pain point iirc.

@Alexandermjos
Copy link

Would it be an alternative to use Java's "new" built in HttpClient? Support both send() and sendAsync().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants