Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS GPGSAppController.m Causes Issues with Other Plugins #11

Closed
kromenak opened this issue Jan 14, 2014 · 2 comments
Closed

iOS GPGSAppController.m Causes Issues with Other Plugins #11

kromenak opened this issue Jan 14, 2014 · 2 comments
Labels

Comments

@kromenak
Copy link

I was having an issue where my Facebook authentication method stopped working after adding the Google Play Games plugin. Upon further inspection, I found the problem was that this plugin extends UnityAppController and overrides the application:openURL method without calling the base implementation, which my Facebook plugin relies on.

There doesn't seem to be any harm in calling the base implementation, and it ensures that any other plugins relying on the default behavior function correctly. Here's the change I made in GPGSAppController.m:

- (BOOL)application:(UIApplication *)application
            openURL:(NSURL *)url
  sourceApplication:(NSString *)sourceApplication
         annotation:(id)annotation {

    NSLog(@"Calling super implementation of openURL.");
    [super application:application openURL:url sourceApplication:sourceApplication annotation:annotation];

    return [GPPURLHandler handleURL:url
                  sourceApplication:sourceApplication
                         annotation:annotation];
}

As an extension of this, it would be ideal if the plugin didn't override UnityAppController, as that can potentially clash with other plugins - but I'm not too good with Obj-C or native iOS development, so maybe it isn't so easy.

@btco
Copy link

btco commented Jan 31, 2014

Definitely. I'll fix this soon.

[internal tracking# 12836543]

@btco
Copy link

btco commented Feb 19, 2014

Fixed in 0.8.01.

@btco btco closed this as completed Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants