Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

negative balance is possible after 1.4-beta2 #522

Closed
antonraharja opened this issue Jun 22, 2016 · 2 comments · Fixed by #524
Closed

negative balance is possible after 1.4-beta2 #522

antonraharja opened this issue Jun 22, 2016 · 2 comments · Fixed by #524
Labels
confirmed
Milestone
1.4

Comments

@antonraharja
Copy link
Member

race condition occurred between playsmsd ratesmsd and sendsmsd
@antonraharja antonraharja added this to the 1.4 milestone Jun 22, 2016
@antonraharja
Copy link
Member Author

related to #502 #515

@antonraharja
Copy link
Member Author

antonraharja commented Jun 25, 2016 •
edited

the plan is to add an adhoc_credit. an adhoc_credit is a field that will be used as a reference for counting credits when sending SMS. adhoc_credit will be used by rate_cansend() and be deducted whenever required, it will be update when the credit (real credit) field is finally updated by ratesmsd

@antonraharja antonraharja mentioned this issue Jun 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

minimize negative balance due to change sin 1.4-beta2 playsms/playsms
1 participant
@antonraharja