Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefer web first assertion rule #287

Merged

Conversation

An631
Copy link
Contributor

@An631 An631 commented Apr 18, 2024

Fixes the following issue:
#286

I have also added new tests to verify this scenario.

@An631
Copy link
Contributor Author

An631 commented Apr 18, 2024

@mskelton I see you have made most of the changes to this rule.
Do you mind taking a looking whenever you have time? Thanks!

@mskelton
Copy link
Member

Please fix the formatting errors with Prettier before submitting. I'll take a look once the formatting and linting is fixed.

@An631
Copy link
Contributor Author

An631 commented Apr 19, 2024

@mskelton I have formatted the files with the command pnpm fmt. Although I did notice that prettier was also formatting two more files unrelated to my changes and I couldn't make prettier run without them. I figured it wouldn't harm anyone having those properly formatted as well in this PR so just kept them in there. Looks like the checks are passing now but please let me know if I missed something and thanks for taking a look.

1 similar comment
@An631

This comment was marked as duplicate.

@mskelton mskelton merged commit b0fb7cd into playwright-community:main Apr 20, 2024
3 checks passed
@mskelton
Copy link
Member

Thanks!

Copy link

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants