Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resetContext should accept options for new context #212

Closed
creage opened this issue Jul 10, 2020 · 3 comments · Fixed by #213
Closed

resetContext should accept options for new context #212

creage opened this issue Jul 10, 2020 · 3 comments · Fixed by #213
Labels
enhancement New feature or request

Comments

@creage
Copy link

creage commented Jul 10, 2020

Is your feature request related to a problem? Please describe.
In our tests we need to run a page using different users, and we used to reset context, and set new HTTP credentials. But recent version of Playwright warns that

warning: method |context.setHTTPCredentials()| is deprecated. Instead of changing credentials, create another browser context with new credentials.

Describe the solution you'd like
jestPlaywright.resetContext() creates new context already, but with context options defined in its initial config. It would be nice if this method can accept additional context options, and merge them with initial options.

Describe alternatives you've considered
We are already using custom Playwright environment, and we can just overwrite resetContext method with our custom implementation, but we believe this feature would give value to entire community.

@mmarkelov mmarkelov added the enhancement New feature or request label Jul 10, 2020
@mmarkelov
Copy link
Member

@creage make sense. Thanks for your report

@creage
Copy link
Author

creage commented Jul 17, 2020

@mmarkelov thank you very much. When should we expect a new release with this fix?

@mmarkelov
Copy link
Member

@creage it is available in next release. I hope the next stable version will be ready on the next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants