Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new playwright version #33

Closed
mmarkelov opened this issue Feb 14, 2020 · 5 comments · Fixed by #39
Closed

Migrate to new playwright version #33

mmarkelov opened this issue Feb 14, 2020 · 5 comments · Fixed by #39

Comments

@mmarkelov
Copy link
Member

Playwright 0.11.0 was released, as I know there were some changes with API, so it can need some changes to current implementation
#30

@schindld
Copy link

This still isn't working for me. I'm using the "'jest-playwright-preset-example" as my starting point. I updated the package.json to include

  "devDependencies": {
    "jest": "^25.1.0",
    "jest-playwright-preset": "mmarkelov/jest-playwright#master",
    "playwright-chromium": "0.11.0"
  },
  "jest": {
    "preset": "jest-playwright-preset"
  }

because you merged in support for 0.11.0 this morning.

Next, I update the lock file: npm install --no-optional --package-lock-only.

Then I saw you were installing libgbm in your workflow file, so after copying the package files into my docker image, I run apt-get update && apt-get install -y libgbm-dev && npm install.

The npm install fails with ENOENT: no such file or directory, chmod '/usr/src/app/node_modules/jest-playwright-preset/lib/bin/index.js'.

So, what am I missing?

@schindld
Copy link

Looks like you have a build script that has to run in order to get that file in place, so I can't just use master - I have to wait for a release.

@mxschmitt
Copy link
Member

Exactly, you have to wait for a release 👍

@mmarkelov
Copy link
Member Author

@schindld I just released 0.0.10, sorry but I just hadn't time to do it yesterday.

This still isn't working for me. I'm using the "'jest-playwright-preset-example" as my starting point. I updated the package.json to include

  "devDependencies": {
    "jest": "^25.1.0",
    "jest-playwright-preset": "mmarkelov/jest-playwright#master",
    "playwright-chromium": "0.11.0"
  },
  "jest": {
    "preset": "jest-playwright-preset"
  }

I suppose I can add actual build to git for this case

@schindld
Copy link

Thanks @mmarkelov
I love the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants