Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-work how jestPlaywright.debug() works under the hood (or remove it completely?) #608

Closed
thernstig opened this issue Mar 1, 2021 · 3 comments · Fixed by #618
Closed
Labels
enhancement New feature or request

Comments

@thernstig
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Playwright supports debugging out of the box. E.g. one can use page.pause() to stop execution in a script (if running in headed/headful mode). In addition, one can set PWDEBUG=1 which will automatically set Playwright to use headful mode as well as disable all timeouts.

jestPlaywright.debug() is a current, hacky solution that came with jest-puppeteer. It would be good if it is re-worked instead to work better with Playwright's debugging tools/options (and Jest's as well, where applicable).

Describe the solution you'd like
I will leave this to your discretion. But setting PWDEBUG=1 could probably be the way for jest-playwright to also set all its debug?

Describe alternatives you've considered
No idea.

Additional context
Check comments at #596 (comment)

@mxschmitt
Copy link
Member

mxschmitt commented Mar 1, 2021

I would vote to remove this functionality and the users should use page.pause instead.

@thernstig
Copy link
Contributor Author

You mean page.pause()?

@thernstig
Copy link
Contributor Author

Oh, and I agree. That would definitely be a simple solution to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants