Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.0 version comes still with playwright-core 1.8.0 #623

Closed
daliusd opened this issue Mar 8, 2021 · 3 comments · Fixed by #625
Closed

1.5.0 version comes still with playwright-core 1.8.0 #623

daliusd opened this issue Mar 8, 2021 · 3 comments · Fixed by #625

Comments

@daliusd
Copy link

daliusd commented Mar 8, 2021

jest-playwright installs playwright-core with itself. For some reason 1.5.0 version installs playwright-core 1.8.0 (while I see that dependabot increased version to 1.9.1 in jest-playwright). I don't know how you make releases but I guess this is manual process and because of that 1.5.0 was released with playwright-core 1.8.0 (e.g. you have not done complete clean-up of node modules and fresh install).

Why this is problem? I want to install playwright 1.9.1 but I can't because type definitions mismatch and fails, like this:

Property 'pause' is missing in type 'import("/home/runner/work/apskaita/apskaita/node_modules/jest-playwright-preset/node_modules/playwright-core/types/types").Page' but required in type 'import("/home/runner/work/apskaita/apskaita/node_modules/playwright/types/types").Page'.

(see this PR daliusd/apskaita#173 if you want to see more context)

One extra idea: maybe playwright-core should be in peerDependencies to avoid problems like that?

@mmarkelov
Copy link
Member

@daliusd seems like that's coming from https://github.com/playwright-community/expect-playwright
will take a look

@mmarkelov
Copy link
Member

@daliusd just released 1.5.1 that should fix an issue

@daliusd
Copy link
Author

daliusd commented Mar 9, 2021

Thank you for a quick response and fix. 1.5.1 fixed my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants