Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DiscordGateway2HttpMaster to Maven Project Structure #77

Open
moflwi opened this issue Apr 17, 2024 · 2 comments · May be fixed by #190
Open

Refactor DiscordGateway2HttpMaster to Maven Project Structure #77

moflwi opened this issue Apr 17, 2024 · 2 comments · May be fixed by #190
Assignees
Labels
refactor Refactorings/Polishing up things

Comments

@moflwi
Copy link
Collaborator

moflwi commented Apr 17, 2024

What

The current code structure in the Dockerfile is not following best practices and is considered an anti-pattern. The comment # this is super anti-pattern, fix with a proper maven project suggests that the project should be refactored to adhere to a proper Maven project structure.

Where

https://github.com/plengauer/Philbot/blob/main/DiscordGateway2HTTPMaster/Dockerfile#L4

Acceptance Criteria

  • The Dockerfile should reflect the updated Maven project structure.
  • The project should build and run successfully with the new Maven structure.
  • The maven project should work seamlessly with Renovate.
Copy link
Contributor

Hello, thanks for adding an issue for the first time!

@moflwi moflwi added the refactor Refactorings/Polishing up things label Apr 17, 2024
@moflwi moflwi self-assigned this Apr 17, 2024
@plengauer
Copy link
Owner

plengauer commented Apr 17, 2024

I think another requirement should be that it will work with renovate (including a manual version bump thats in the github actions similar to the one for the scheduler, i.e., if a maven dependency is updated, a commit must be added to the PR bumping the minor version. see https://github.com/plengauer/Philbot/blob/main/.github/workflows/bump_version_scheduler.yml)

@moflwi moflwi linked a pull request Jun 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactorings/Polishing up things
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants