Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add invoke method on Prop to enable Kotlin invocation usage #35

Merged
merged 3 commits into from
Apr 15, 2021
Merged

feat: add invoke method on Prop to enable Kotlin invocation usage #35

merged 3 commits into from
Apr 15, 2021

Conversation

erwinw
Copy link
Member

@erwinw erwinw commented Apr 15, 2021

Add invoke method on Prop to enable Kotlin invocation usage

This turns usage of a Prop<Int> in Kotlin from myProp.get() to myProp().

@erwinw erwinw requested review from bbi22 and jsfr as code owners April 15, 2021 11:11
@erwinw erwinw self-assigned this Apr 15, 2021
@jsfr jsfr changed the title Add invoke method on Prop to enable Kotlin invocation usage feat: add invoke method on Prop to enable Kotlin invocation usage Apr 15, 2021
jsfr
jsfr approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@jsfr jsfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)!

NB: I've changed the name of the PR so that when you merge it that becomes the commit message, this ensures that a new version with proper bump will be released automatically.

andersfischernielsen
andersfischernielsen approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@andersfischernielsen andersfischernielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessss, awesome 🎉

@erwinw erwinw enabled auto-merge (squash) April 15, 2021 11:20
@erwinw erwinw merged commit 9bb67bf into master Apr 15, 2021
@erwinw erwinw deleted the feature/prop-invoke branch April 15, 2021 11:21
github-actions bot pushed a commit that referenced this pull request Apr 15, 2021
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
84c77fb 
# [2.2.0](v2.1.0...v2.2.0) (2021-04-15)

### Features

* add invoke method on Prop to enable Kotlin invocation usage ([#35](#35)) ([9bb67bf](9bb67bf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsfr jsfr jsfr approved these changes

@andersfischernielsen andersfischernielsen andersfischernielsen approved these changes

@bbi22 bbi22 Awaiting requested review from bbi22

Assignees

@erwinw erwinw

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erwinw @jsfr @andersfischernielsen