Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd and Even Parity exchanged #170

Closed
CloseToTheEdge opened this issue Jun 17, 2020 · 5 comments
Closed

Odd and Even Parity exchanged #170

CloseToTheEdge opened this issue Jun 17, 2020 · 5 comments
Assignees
Labels

Comments

@CloseToTheEdge
Copy link

Test Version: 6.8.3, 6.7.0
Test Parameter:
SWSERIAL_7O2 == 7 Bit Even Parity
SWSERIAL_7E2 == 7 Bit Odd Parity

@dok-net
Copy link
Collaborator

dok-net commented Jun 17, 2020 via email

@dok-net dok-net closed this as completed Jun 21, 2020
@dok-net dok-net self-assigned this Jun 22, 2020
@dok-net dok-net added bug and removed invalid labels Jun 22, 2020
@dok-net
Copy link
Collaborator

dok-net commented Jun 22, 2020

Dear @CloseToTheEdge, I appreciate the fact that you found this bug, I just equally wish, you had provided more background, like testing more of the modes. The HW serial API in ESP8266/ESP32 disregards parity on RX, so testing against those turns out has been futile previously. I finally found some time to test in depth, and I've found the cause and I am about to fix it.

@dok-net dok-net reopened this Jun 22, 2020
@CloseToTheEdge
Copy link
Author

Still the same Problem: Version 6.8.5

SoftwareSerial swSer;
swSer.begin(1200, SWSERIAL_7O2, D2, D1, false, 256, 256);
TX sends over D1 EVEN parity instead of ODD.

SWSERIAL_7E2 sends ODD parity

(RX not tested)

@dok-net
Copy link
Collaborator

dok-net commented Jun 23, 2020

Are you certain? Have you read the README, in particular the section titled Using and updating EspSoftwareSerial in the esp8266com/esp8266 Arduino build environment?

@dok-net dok-net reopened this Jun 23, 2020
@dok-net dok-net closed this as completed Jun 23, 2020
@dok-net
Copy link
Collaborator

dok-net commented Jun 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants