Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size factors should be positive #32

Closed
Yale73 opened this issue Jan 4, 2021 · 6 comments
Closed

Size factors should be positive #32

Yale73 opened this issue Jan 4, 2021 · 6 comments

Comments

@Yale73
Copy link

Yale73 commented Jan 4, 2021

Hi scDblFinder team,

Thanks for such a great package. Recently, I am using this package to find the doublet cells for my Seurat object. I transferred my Seurat object into single cell experiment, but when I run the scDblFinder, I got an error: Size factors should be positive. My Seurat object has no log-transformation. But even after I log-transformed them, I still got the same error. I also have other datasets and they can run it smoothly. The only difference is the failed datasets have mouse cell spike-in, but I have removed these cells before running scDblFinder. Is there any solution for this issue?

Thanks,
Yale

@plger
Copy link
Owner

plger commented Jan 4, 2021

Hi,
The most likely explanation is that you have cells with a very low read count. Can you check min(colSums(counts(SCE))), where SCE is your singlecellexperiment object?

@Yale73
Copy link
Author

Yale73 commented Jan 4, 2021

Hi @plger ,

Thanks for your reply. The failed ones have min(colSums(counts(SCE))) = 0. I ran the QC first and then the scDblFinder. Now they worked.

Thanks again,
Yale

@plger
Copy link
Owner

plger commented Jan 11, 2021

Added this to the FAQs.
Note that we recommend not filtering too much before running scDblFinder (but removing the droplets not containing cells).

@plger plger closed this as completed Jan 11, 2021
@Yale73
Copy link
Author

Yale73 commented Jan 15, 2021

Hi @plger,

If you recommend not filtering too much, why not recommend us to run scDblFinder first and then filter the cells? As I found if I ran the scDblFinder first and then filter, I will keep a little more high-quality cells.

Object with 4822 cells Singlets Doublets
First scDblFinder 4558 264
Then filter 4493  
     
First filter 4717  
Then scDblFinder 4475 242

Thanks,
Yale

@plger
Copy link
Owner

plger commented Jan 15, 2021

That's actually what I recommend (see for instance in the README, or in the pipeComp paper), however your earlier issue shows that some minimal filtering is needed to at least remove empty (or nearly empty) droplets...

@Yale73
Copy link
Author

Yale73 commented Jan 15, 2021

I see. I forget the filter is to remove the empty, If with empty, I will run the earlier issue.

Thanks,
Yale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants