Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Theme/Color Support #4

Open
bdickason opened this issue Jul 11, 2018 · 3 comments
Open

Adding Theme/Color Support #4

bdickason opened this issue Jul 11, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bdickason
Copy link

I saw in the todo (and HN post) that you'd like to add Color/Theme support. Do you have an idea of how you'd like this to work? I've got some spare time this evening.

@plibither8
Copy link
Owner

Hey! Thanks a lot for wanting to contribute, I really would love it. Adding themes is certainly in my todo list. Right now, the page is completely based on vanilla JS (es6) in a single 'index.js' file. At first glance it might look messy (sorry!) but I think it's workable.

As of the implementation of the 'Theme Changer', I think it's best that we add it in the Settings modal. It will require use of localStorage() to save the preferences, and simple JS to implement the style changes. If you can, I would really appreciate it.

Thanks! 😄

@schroffl
Copy link

Just being able to define the text- and background-color in the settings would be enough for me. I wouldn't want to change anything else but flipping the colors, because the white-on-black is a bit harsh on the eyes.

@plibither8 plibither8 added enhancement New feature or request help wanted Extra attention is needed labels Jul 14, 2018
@plibither8 plibither8 pinned this issue Dec 14, 2018
@jef
Copy link

jef commented Mar 26, 2020

i'd definitely would like to see this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants