fix blacklist in alienfile #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I copied this from the Makefile.PL in XML-LibXML I misunderstood how it worked. Though it makes sense now from the comments. Versions with a .1 suffix are good and .0 suffix are bad. Assume unmentioned are okay?
|
I've added logic to skip the system versions of libxml2 that are known to be bad unless Unfortunately, I think the actual version list for the blacklist is wrong. Looking again at the https://metacpan.org/source/SHLOMIF/XML-LibXML-2.0132/Makefile.PL#L167 So for example, the version of libxml2 in my OS X (High Sierra) is 2.9.4, so this alienfile does a share install unless |
they set the version in the gather stage. This should probably be fixed in AB, at least optionally. In the meanwhile, XML-LibXML doesn't actually probe for libxml2 using pkg-config, so it isn't atm any worse than XML-LibXML, it is just that it could be better.
genio
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I copied this from the Makefile.PL in XML-LibXML I misunderstood how it worked. Though it makes sense now from the comments. Versions with a .1 suffix are good and .0 suffix are bad. Assume unmentioned are okay?