Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with stable rust #48

Closed
plietar opened this issue Feb 18, 2016 · 4 comments
Closed

Building with stable rust #48

plietar opened this issue Feb 18, 2016 · 4 comments

Comments

@plietar
Copy link
Owner

plietar commented Feb 18, 2016

Since librespot was started rust has stabilized a lot of stuff. As a result where lots of unstable features were required before, only zero_one, iter_arith, and plugin are needed now.

The first two are trivial to work around.
The last one not so much. The two plugins used are json_macros, which could easily be avoided, and protobuf_macros which is used a lot and would be a pain to get rid, both in terms of work and readability.

syntex would be a potential solution to this.

@plietar plietar mentioned this issue Feb 21, 2016
@plietar
Copy link
Owner Author

plietar commented Mar 7, 2016

Building on rust stable now works (d27c4ca).
I'm keeping this open until I update the README.

@herrernst
Copy link
Contributor

This is great news! There is one last gotcha when building with discovery: plietar/rust-dns-sd#2
Thank you!

@plietar
Copy link
Owner Author

plietar commented Mar 7, 2016

Oops, good catch thanks.
I probably need to update Cargo.lock as well, I'll do that when I get back this evening.

@plietar
Copy link
Owner Author

plietar commented Mar 11, 2016

README has been updated, with instructions on how to build without syntex.
Travis also builds using stable, beta and nightly, making sure stable support doesn't break unexpectedly.

@plietar plietar closed this as completed Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants