You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running flake8 with flake8-noqa and flake8-todo both installed the user is stuck having either the T000 warning about the TODO or the NQA102. I'm guessing this is related to the behaviour previously partially discussed in #26, though slightly different.
I've tried putting the noqa comment both before and after the TODO comment, neither of those works.
The text was updated successfully, but these errors were encountered:
This is an issue in flake8-todo, specifically these lines need to be simply removed. (And the pycodestyle import and dependency in setup.py can be removed too.)
flake8-todo is checking for the existence of a #noqa comment and not reporting the violation if present. This is an anti-pattern. flake8-todo should simply report the violation and let flake8 filter out the #noqa.
Given the following code:
# TODO: make this better # noqa: T000
When running
flake8
withflake8-noqa
andflake8-todo
both installed the user is stuck having either theT000
warning about the TODO or theNQA102
. I'm guessing this is related to the behaviour previously partially discussed in #26, though slightly different.I've tried putting the noqa comment both before and after the TODO comment, neither of those works.
The text was updated successfully, but these errors were encountered: