Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click-through on milestone with no children shouldn't be allowed #62

Closed
reidlw opened this issue Nov 7, 2022 · 3 comments · Fixed by #94 or #190
Closed

Click-through on milestone with no children shouldn't be allowed #62

reidlw opened this issue Nov 7, 2022 · 3 comments · Fixed by #94 or #190
Assignees
@whizzzkid
Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P0 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs

Comments

@reidlw
Copy link
Contributor

reidlw commented Nov 7, 2022

Currently you can click-through on a milestone with no children, which results in an empty page with a message "not found"
@juliaxbow juliaxbow mentioned this issue Nov 10, 2022
Closed
@SgtPooki SgtPooki added bug Something isn't working MVP P0 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs labels Nov 11, 2022
@SgtPooki SgtPooki mentioned this issue Nov 11, 2022
Open
5 tasks
@reidlw
Copy link
Contributor Author

reidlw commented Nov 13, 2022

@SgtPooki - I don't think this is error handling issue; this is a navigation issue. We don't need a better error message, we need to disable ability to click to "zoom in" on an issue that doesn't have children.

@SgtPooki SgtPooki added the effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete label Nov 14, 2022
@SgtPooki
Copy link
Contributor

@wilkyr31d yes, I agree, but this is an error state that needs to be handled by blocking, versus an error state that needs to be handled by rendering an error. This is a UX Gotcha that is not currently handled.

@whizzzkid whizzzkid self-assigned this Nov 15, 2022
@whizzzkid whizzzkid mentioned this issue Nov 15, 2022
Merged
@juliaxbow
Copy link
Collaborator

Description:
In "Detailed View," for at least one roadmap, milestones with no children are clickable and lead to an error (after appearing to show the parent milestone in "Overview")

Recreate:

What should happen:

  • Milestone cards with no children shouldn't be clickable

See vid:

Child.Issues.Bug.mov

@juliaxbow juliaxbow reopened this Nov 25, 2022
@whizzzkid whizzzkid mentioned this issue Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P0 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs
Projects
Starmap
Archived in project
Milestone
No milestone
4 participants
@SgtPooki @whizzzkid @reidlw @juliaxbow