Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default resource limits and requests to pod defintions #52

Closed
itewk opened this issue Jul 27, 2021 · 2 comments · Fixed by #56
Closed

add default resource limits and requests to pod defintions #52

itewk opened this issue Jul 27, 2021 · 2 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects

Comments

@itewk
Copy link
Contributor

itewk commented Jul 27, 2021

purpose

Add default resource limits and and requests to pod definitions so reference workflows work in environments with quotas.

implementation

we should have "sane" defaults, but also make them a parameter that can be overwritten.

related

@itewk itewk added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 27, 2021
@itewk itewk added this to To Do in ploigos via automation Jul 27, 2021
@cmasonrh
Copy link
Contributor

@itewk I'm working on this if you want to assign it to me. Should be ready to PR today.

@cthiel1
Copy link

cthiel1 commented Dec 13, 2021

Hey @cmasonrh ian is out on PTO through Jan. I assigned you!

@cmasonrh cmasonrh mentioned this issue Dec 13, 2021
ploigos automation moved this from To Do to Done Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Development

Successfully merging a pull request may close this issue.

3 participants