Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-remove IContentish from site root class #3833

Closed
jaroel opened this issue Aug 16, 2023 · 1 comment · Fixed by #3836
Closed

Un-remove IContentish from site root class #3833

jaroel opened this issue Aug 16, 2023 · 1 comment · Fixed by #3836

Comments

@jaroel
Copy link
Member

jaroel commented Aug 16, 2023

On

# Remove the IContentish interface so we don't listen to events that won't
I remove IContentish, because having it broke tests and setup code in places that I didn't feel like touching.

Nowadays we have some test failures because of the removal. See plone/plone.restapi#1674 (comment) for additional details, but suffice to say that conversation_view is expected to exist on the site root, but isn't because it's bound to IContentish.

@jaroel
Copy link
Member Author

jaroel commented Oct 11, 2023

The removal of IContentish seems to also remove plone.app.relationfield.interfaces.IDexterityHasRelations (for PloneSite) . Which is weird to me because IDexterityHasRelations is set on the class plone.dexterity.context.Content, not as a subclass of IContentish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant