Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in documentation #1095

Closed
dbitouze opened this issue Sep 13, 2019 · 8 comments
Closed

Typo in documentation #1095

dbitouze opened this issue Sep 13, 2019 · 8 comments

Comments

@dbitouze
Copy link
Contributor

dbitouze commented Sep 13, 2019

If I'm right, there's a typo line 172 of https://github.com/plone/documentation/blob/5.2/manage/upgrading/version_specific_migration/upgrade_zodb_to_python3.rst. It should be:

parts +=

instead of:

parts =+

@ale-rt
Copy link
Member

ale-rt commented Sep 13, 2019

True! You can fix this directly on github:
https://github.com/plone/documentation/edit/5.2/manage/upgrading/version_specific_migration/upgrade_zodb_to_python3.rst
but remember to write a meaningful changelog and to select the radio button "Create a new branch for this commit and start a pull request"

@dbitouze
Copy link
Contributor Author

I preferred to just open an issue since I didn't sign the Plone Contributor Agreement that lets me merge pull requests.

@ale-rt
Copy link
Member

ale-rt commented Sep 13, 2019

Documentation does not require it, right @plone/documentation-team

@tkimnguyen
Copy link
Sponsor Member

tkimnguyen commented Sep 13, 2019 via email

@tkimnguyen
Copy link
Sponsor Member

tkimnguyen commented Sep 13, 2019 via email

@dbitouze
Copy link
Contributor Author

Done (hope the changelog is meaningful enough).

@polyester
Copy link
Sponsor Member

Just to weigh in: a simple typo does not need a contributor agreement, as it does not constitute a "work" in copyright law. Of course, @dbitouze you are very welcome to sign one anyway and enjoy the warm fuzzy feeling of being a fully-fledged Plone contributor ;-)

There's not a super-clear division line between what is a "work" and what is not, but a few-characters typo definitely doesn't need a Contributor Agreement.

@spereverde
Copy link
Sponsor Member

thanks for fixing this @dbitouze 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants