Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken link to plone contributor agreement #672

Closed
oz123 opened this issue Jul 26, 2016 · 7 comments
Closed

broken link to plone contributor agreement #672

oz123 opened this issue Jul 26, 2016 · 7 comments

Comments

@oz123
Copy link

oz123 commented Jul 26, 2016

http://docs.plone.org/develop/coredev/docs/agreement.html

The link for the agreement has a typo: http://plone.org/foundation/contributors-agreement/agreement.pdf/at_download/file.

@svx
Copy link
Member

svx commented Jul 26, 2016

This is already fixed in: plone/buildout.coredev@b99a706

It will be updated on docs.plone.org with the next docs release

@svx svx closed this as completed Jul 26, 2016
@oz123
Copy link
Author

oz123 commented Jul 26, 2016

Thanks for the quick reply. We should port this fix to the 5.0 branch too. I will do a separate PR.

@ableeb ableeb reopened this Jan 13, 2018
@ableeb
Copy link
Member

ableeb commented Jan 13, 2018

I received this issue report about the contributor’s agreement link from someone submitting a contributors agreement.

Please note that the link text on https://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html#contributors-agreement-for-plone-explained is https://plone.org/foundation/contributors-agreement/agreement.pdf alright, but the clickable text is not; instead, it simply reloads the page, and thus causes some confusion.

This is the rendered link
https://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html#id1

This is the text:
The Plone Contributor Agreement can be found at: https://plone.org/foundation/contributors-agreement/agreement.pdf_

@svx
Copy link
Member

svx commented Jan 14, 2018

Fixed again in plone/buildout.coredev#386, will be online after the PR is merged with the next deployment of the docs.

@ableeb
Copy link
Member

ableeb commented Jan 14, 2018

@svx Thx!
cc @tobiasherp who reported it

@tkimnguyen
Copy link
Sponsor Member

That link really should point instead to https://plone.org/foundation/contributors-agreement/ rather than directly to the PDF, and IMO the duplicated information (on docs.plone.org and on plone.org) is going to cause us grief. I will take this over to plone/buildout.coredev#386

@stevepiercy
Copy link
Contributor

This was fixed years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants