New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use orjson 3.x #1062
Use orjson 3.x #1062
Conversation
@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html |
I think @bloodbare wanted to wait for G7 to upgrade this dep. We'll start G7 development in the following weeks. Maybe we can use that version for the benchmark |
We can update it on 6.X , I've verified that does not break anything! |
@waghanza you should sign Plone contribution agreement and modify the changelog to have a valid PR. |
Sure @bloodbare. I'll check how to create a proper changelog entry |
@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html |
done @mister-roboto |
can you push another commit to trigger the bot, please? |
@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html |
@masipcat I thought I've signed the agreement |
Close then reopen this PR to get the robot to rescan for your contributors agreement |
Hi,
As
orjson
3.x has many fixes, see https://github.com/ijl/orjson/releases, I can suggest to use this version instead of 2.6.0Besides, it will fix the-benchmarker/web-frameworks#3600
Regards,