Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use orjson 3.x #1062

Closed
wants to merge 3 commits into from
Closed

Use orjson 3.x #1062

wants to merge 3 commits into from

Conversation

waghanza
Copy link
Contributor

Hi,

As orjson 3.x has many fixes, see https://github.com/ijl/orjson/releases, I can suggest to use this version instead of 2.6.0

Besides, it will fix the-benchmarker/web-frameworks#3600

Regards,

@mister-roboto
Copy link

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

@masipcat
Copy link
Contributor

masipcat commented Dec 14, 2020

I think @bloodbare wanted to wait for G7 to upgrade this dep. We'll start G7 development in the following weeks. Maybe we can use that version for the benchmark

@bloodbare
Copy link
Member

We can update it on 6.X , I've verified that does not break anything!

@bloodbare
Copy link
Member

@waghanza you should sign Plone contribution agreement and modify the changelog to have a valid PR.

@waghanza
Copy link
Contributor Author

Sure @bloodbare. I'll check how to create a proper changelog entry

@mister-roboto
Copy link

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

@waghanza
Copy link
Contributor Author

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

done @mister-roboto

@masipcat
Copy link
Contributor

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

done @mister-roboto

can you push another commit to trigger the bot, please?

@mister-roboto
Copy link

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

@waghanza
Copy link
Contributor Author

@masipcat I thought I've signed the agreement

@ableeb
Copy link
Member

ableeb commented Dec 14, 2020

Close then reopen this PR to get the robot to rescan for your contributors agreement

@waghanza waghanza closed this Dec 14, 2020
@waghanza waghanza deleted the deps/orjson/v3 branch December 14, 2020 20:24
@waghanza waghanza mentioned this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants