Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

being able to call do_action with super powers using the utility #1175

Merged
merged 2 commits into from Aug 25, 2022

Conversation

nilbacardit26
Copy link
Contributor

In some situations in my internal code, I want to be able to switch the state of the workflow on behalf of other users without checking any security policies.

guillotina/contrib/workflows/utility.py Outdated Show resolved Hide resolved
Copy link
Member

@vangheem vangheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to run the file through black? It's failing the formatting check.

@nilbacardit26
Copy link
Contributor Author

yeap, now it should be fine

@nilbacardit26
Copy link
Contributor Author

seems that there are some tests failing including the ones of the workflow, let me check this out @vangheem

@nilbacardit26
Copy link
Contributor Author

nilbacardit26 commented Aug 24, 2022

seems like there is an error with the pytest_docker_fixtures, related to docker. For some reason, when trying to pull/run any docker fixture image we get a 404:
404 Client Error: Not Found for url: http+docker://localhost/v1.23/containers/create

I need to dig a little bit more, it works fine on my computer. It might be related to that:
docker/docker-py#2101 (comment)

@vangheem
Copy link
Member

oh dang, CI is busted!

I won't have time to look at it to fix unfortunately.

@nilbacardit26 will you be able to use a manual release from your branch while it gets sorted?

@nilbacardit26
Copy link
Contributor Author

@vangheem yes, that would suffice! Thank you

@masipcat
Copy link
Contributor

I think pinning docker (dockerpy) to < 6.0 will fix the issue

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #1175 (2c7d94b) into master (0e4bb3d) will increase coverage by 0.1%.
The diff coverage is 80.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1175     +/-   ##
========================================
+ Coverage    94.6%   94.6%   +0.1%     
========================================
  Files         377     377             
  Lines       32654   32655      +1     
========================================
+ Hits        30876   30877      +1     
  Misses       1778    1778             
Impacted Files Coverage Δ
guillotina/contrib/workflows/utility.py 92.6% <80.0%> (+0.1%) ⬆️

@nilbacardit26
Copy link
Contributor Author

@masipcat thank you! now it is working :)

@bloodbare bloodbare merged commit 8a5c6e3 into master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants