Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce layers split #167

Open
gforcada opened this issue Jul 15, 2023 · 4 comments
Open

enforce layers split #167

gforcada opened this issue Jul 15, 2023 · 4 comments
Labels
04 type: enhancement making existing stuff better 14 prio: low nice to have it fixed 43 lvl: complex for wizards

Comments

@gforcada
Copy link
Sponsor Member

gforcada commented Jul 15, 2023

We are moving a few addons to be core-addons, plone.api should not be used in a few places, but fine in others...

That's all great but in practicality impossible to double check manually on a PR basis unless you have a tool... 🥁 enters import-linter:

https://import-linter.readthedocs.io/en/stable/index.html

Although the main use case is to check dependencies between packages of a single python distribution, it says on the docs that it can handle external packages as well ✨🍀

That sounds like the perfect fit to our organization layer cleanup, right?

@jensens @mauritsvanrees

@jensens
Copy link
Sponsor Member

jensens commented Jul 18, 2023

Wow, this sounds like a great tool. -> Wanna have!
This could be expanded in future for other checks as well.

@mauritsvanrees
Copy link
Sponsor Member

Cool!

@mauritsvanrees
Copy link
Sponsor Member

The Python Weekly Newsletter has an article on organising a large code base with layers, and it also mentions import-linter:
https://blog.europython.eu/kraken-technologies-how-we-organize-our-very-large-pythonmonolith/

@gforcada
Copy link
Sponsor Member Author

gforcada commented Jul 20, 2023

Yes, I took it from there 😄

@gforcada gforcada added 04 type: enhancement making existing stuff better 14 prio: low nice to have it fixed 43 lvl: complex for wizards labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04 type: enhancement making existing stuff better 14 prio: low nice to have it fixed 43 lvl: complex for wizards
Projects
None yet
Development

No branches or pull requests

3 participants