Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moment-pattern does not use locales #464

Closed
pbauer opened this issue Feb 17, 2015 · 3 comments
Closed

moment-pattern does not use locales #464

pbauer opened this issue Feb 17, 2015 · 3 comments

Comments

@pbauer
Copy link
Sponsor Member

pbauer commented Feb 17, 2015

While experimenting with replacing date-formating in plone.app.contenttypes with the moment-pattern (http://plone.github.io/mockup/dev/#pattern/moment) I realized that it does not use the current locales. This shoud to be done by default otherwise the pattern will be useless.

@vangheem
Copy link
Member

Will it need to use plone locales or can we integrate with moment's locales?

@pbauer
Copy link
Sponsor Member Author

pbauer commented Feb 17, 2015

I doubt has Plone has same locales as moment.js since Plone has country-specific locales such as en_AU. We might have to map one to the other.

@vangheem
Copy link
Member

Fixed here: plone/Products.CMFPlone@87110c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants