Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create preview build #4

Closed
stevepiercy opened this issue May 6, 2024 · 7 comments
Closed

Create preview build #4

stevepiercy opened this issue May 6, 2024 · 7 comments

Comments

@stevepiercy
Copy link
Contributor

No description provided.

@stevepiercy
Copy link
Contributor Author

Uh-oh. https://answers.netlify.com/t/the-current-python-version-3-8-is-very-old/96966/4

To answer your question, yes there are some technical limitations due to which we’re sticking on Python 3.8. Allowing newer versions would require a bigger engineering lift and that’s not something prioritised in the short-term. Seeing your question, I did ask out devs about the status, and it’s still “not planned in any short-term roadmap”.

Meanwhile:

https://fosstodon.org/@orsinium/110807654189402872

I just migrated pythonetc.orsinium.dev from #netlify to #cloudflare pages.

Cloudflare pros: Python 3.11 (Netlify is still on 3.8 and no plans to ever upgrade), amazing analytics, unlimited free bandwidth.

Netlify pros: more configuration options, has a config file, friendlier UI.

Both provide PR previews and are easy to use and fast to set up.

@stevepiercy stevepiercy changed the title Create Netlify preview build Create Netlify or Cloudflare Pages preview build May 8, 2024
@stevepiercy
Copy link
Contributor Author

stevepiercy commented May 8, 2024

We need to migrate from Netlify or stop using it. Sphinx Book Theme requires Python 3.9+, and Netlify supports only Python 3.8. 💩

https://app.netlify.com/sites/plone-sphinx-theme/deploys/663b5147d6be0c00083499ad#L218

@stevepiercy
Copy link
Contributor Author

Looks like Cloudflare Pages is the way to go. Example: life4/pythonetc#53 (comment)

@stevepiercy
Copy link
Contributor Author

stevepiercy commented May 9, 2024

Maybe not. I had no luck in #7. I looked at Vercel, and got overwhelmed.

I also looked at https://github.com/marketplace/actions/deploy-pr-preview, but this works only with GitHub Pages classic and a specific branch, not the latest version through GitHub Actions. See rossjrw/pr-preview-action#21 (comment).

GitHub has this feature that they have in alpha and for their internal use only for the last two years, but it is unknown if or when it will become public. See https://github.com/orgs/community/discussions/7730#discussioncomment-7603270.

@stevepiercy
Copy link
Contributor Author

It looks like Read The Docs is possible, either through GHA or a webhook. I asked in the Python Docs Discord.

https://github.com/readthedocs/actions/tree/v1/preview

Before I begin, does the Plone Foundation have a RTD organization with subprojects?

Pylons Project has one.

Screenshot 2024-05-09 at 2 56 46 PM

Here's breadcrumbs of Pyramid.

Screenshot 2024-05-09 at 2 59 04 PM

It looks like plone.restapi is a single organization-less project.

Screenshot 2024-05-09 at 2 58 53 PM

@polyester @tisto @ericof @sneridagh @tkimnguyen @mauritsvanrees @fredvd might any of you know? If there is none, should we set one up?

@stevepiercy stevepiercy changed the title Create Netlify or Cloudflare Pages preview build Create preview build May 10, 2024
@stevepiercy
Copy link
Contributor Author

We might not actually want an organization with sub-projects because we cannot have custom domains for each one. The pattern is:

custom.plone.org/projects/<subproject>/

With each project as a plain old project, we can do this:

<project>.plone.org

There are some advantages to subprojects, including being able to search across them and to use a single domain name for each, but I don't think those features are worth it.

Anyway, for now, we have https://plone-sphinx-theme.readthedocs.io/.

We could set up a custom domain of https://plone-sphinx-theme.plone.org/. @polyester @fredvd what are your thoughts about doing this?

@stevepiercy
Copy link
Contributor Author

Closed by #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant