Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE menu position not recalculated on scroll #369

Open
frapell opened this issue Jun 13, 2017 · 4 comments
Open

TinyMCE menu position not recalculated on scroll #369

frapell opened this issue Jun 13, 2017 · 4 comments

Comments

@frapell
Copy link
Sponsor Member

frapell commented Jun 13, 2017

This is related to #301

When you open a tinymce drop down for the richtext tile, and you scroll down so the toolbar position is fixed on top, opened menues position are not recalculated.

Here's a video showing the issue: https://drive.google.com/open?id=0B94hTF3v42BteUliQjlHdVZTdms

This is happening in latest master

@frapell
Copy link
Sponsor Member Author

frapell commented Jun 13, 2017

@datakurre Also, check http://fiddle.tinymce.com/7Sfaab/1 is mosaic maybe preventing some event to be fired when going from float to fixed?

@datakurre
Copy link
Member

@frapell I don't know. I haven't looked how Nathan implemented that stickyness. It could also be CSS related issue, because calculating vertical stuff is tricky. Already #301 was hard to discover :/

@frapell
Copy link
Sponsor Member Author

frapell commented Jun 13, 2017

yeah, it took me quite some time to find... I notice how the "top" property for the menu change when switches from float to sticky on default tinymce (As in the fiddle link I posted), but it doesn't in Plone, so I thought there might be an event that is not firing in Plone...

I'll keep digging.

@vangheem thoughts?

@datakurre
Copy link
Member

@frapell It's interesting that in fiddle TinyMCE behaves well out of the box, but in Mosaic Nathan had to add manual stickyness handling. That might be why "top" is missing.

https://github.com/plone/plone.app.mosaic/blob/master/src/plone/app/mosaic/browser/static/js/mosaic.tile.js#L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants