Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plone 5.2.2 release #138

Closed
avoinea opened this issue Aug 17, 2020 · 16 comments
Closed

Plone 5.2.2 release #138

avoinea opened this issue Aug 17, 2020 · 16 comments
Assignees
Labels
37 needs: release New Plone release

Comments

@avoinea
Copy link
Sponsor Member

avoinea commented Aug 17, 2020

See https://launchpad.net/plone/5.2/5.2.2

@avoinea avoinea added the 37 needs: release New Plone release label Aug 17, 2020
@avoinea avoinea self-assigned this Aug 17, 2020
@mauritsvanrees
Copy link
Sponsor Member

Kim has made the 5.2.2 Universal Installer available on launchpad: https://launchpad.net/plone/5.2/5.2.2/

@avoinea
Copy link
Sponsor Member Author

avoinea commented Sep 16, 2020

@svx Can you please give me admin rights on this repo as I can't edit tags on docker-hub anymore: https://hub.docker.com/repository/docker/plone/plone/builds/edit

@svx
Copy link
Member

svx commented Sep 16, 2020

@avoinea you are owner, you have the same permissions like Me and all the others, I just checked, we did not changed anything.

Weird that it is not working anymore, still pretty much in line with my experience with Docker Ub over the last couple of months ... :(

@avoinea
Copy link
Sponsor Member Author

avoinea commented Sep 16, 2020

@svx The problem is that I can't link github repo anymore:

docker-hub

Thus, I suppose I need more rights on github, not on DockerHub.

@svx
Copy link
Member

svx commented Sep 16, 2020

@avoinea QUestion why is this pointing to simple-plone-buildout? :)

@avoinea
Copy link
Sponsor Member Author

avoinea commented Sep 16, 2020

@svx it's not, is the only option I can select.

@svx
Copy link
Member

svx commented Sep 16, 2020

I do not even have permissions to edit anything

Error: Error trying to get GitHub user: 401 Client Error: Unauthorized for url: https://api.github.com/user.

Man I HATE Docker Hub, the permission system is crap !

@svx
Copy link
Member

svx commented Sep 16, 2020

@plone/ai-team can someone else look into this, too? My time this week is very limited as in I have no time.

I guess this has something todo with ongoing account changes we have/had with Docker Hub, since the account was first linked to a personal account and afterwards changed a couple of times.

@avoinea
Copy link
Sponsor Member Author

avoinea commented Sep 16, 2020

Indeed, now is linked to my personal account 😄

@svx
Copy link
Member

svx commented Sep 16, 2020

Yeah and this should not happen :) If I remember right, we created a docker-service-user and since how permissions are working on Docker Hub I guess you would need to login as this user.

Someone needs to check if that is really the case and if you the @plone/ai-team has to give you the credentials.

@avoinea
Copy link
Sponsor Member Author

avoinea commented Sep 16, 2020

Someone needs to check if that is really the case and if you the @plone/ai-team has to give you the credentials.

@bloodbare Fixed it. Thank you!

@avoinea
Copy link
Sponsor Member Author

avoinea commented Sep 16, 2020

Kim has made the 5.2.2 Universal Installer available on launchpad: https://launchpad.net/plone/5.2/5.2.2/

@mauritsvanrees Is this release supposed to work also with Python2?

Either way, I don't think Docker accepts any longer Python 2 based images for official images pull-request.
@tianon is this right?

@bloodbare
Copy link
Member

bloodbare commented Sep 16, 2020

@svx @plone/ai-team

  • docker hub needs that linked account has owner permission to set an ssh key
  • that who sets the repo has owner permission also to link the repo
  • dockerplone github user has 2FA and no mailing list linked
  • I created dockerhubplone github user with a gsuite mailing list dockerhub@pl....org (right now there is my user but feel free to add whoever needs to be there)
  • I needed to set owner permission for dockerhubplone github user
  • Relinked plone docker hub account with dockerhubplone github user
  • Reset to plone/plone.docker repo the plone docker hub repo
  • Restart plone docker hub repo, volto docker hub repo and guillotina_cms docker hub repo so keys are republished on respective repositories

Now Volto, GuillotinaCMS and Plone automated builds work again.

Sorry if I took the fast path to create a new user, feel free to fix it in a better way

@tisto @avoinea

@mauritsvanrees
Copy link
Sponsor Member

Is this release supposed to work also with Python2?

Yes: Python 2.7, 3.6, 3.7, 3.8.
Anyone migrating in-place from 5.1 to 5.2 must first have a 5.2 running on Python 2, before migrating the database to Python 3.

@tianon
Copy link
Contributor

tianon commented Sep 17, 2020

Either way, I don't think Docker accepts any longer Python 2 based images for official images pull-request.
@tianon is this right?

That's correct -- Python 2 is completely EOL and removed from the library.

@avoinea
Copy link
Sponsor Member Author

avoinea commented Sep 21, 2020

Plone 5.2.2 released https://hub.docker.com/_/plone

For Python 2 tags use plone/plone

Happy hacking!

@avoinea avoinea closed this as completed Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
37 needs: release New Plone release
Projects
None yet
Development

No branches or pull requests

5 participants