Buildout fails if [unifiedinstaller] clients = is set

[miohtama]

I encountered this already second time with different buildouts, so this might be a bug

I think something has changed in plone.recipe.unifiedinstaller recently

You get

An internal error occured due to a bug in either zc.buildout or in a
recipe being used:
Traceback (most recent call last):
  File "/srv/plone/levitunturi/hotellilevitunturi/eggs/zc.buildout-1.4.3-py2.4.egg/zc/buildout/buildout.py", line 1660, in main
    getattr(buildout, command)(args)
  File "/srv/plone/levitunturi/hotellilevitunturi/eggs/zc.buildout-1.4.3-py2.4.egg/zc/buildout/buildout.py", line 532, in install
    installed_files = self[part]._call(recipe.install)
  File "/srv/plone/levitunturi/hotellilevitunturi/eggs/zc.buildout-1.4.3-py2.4.egg/zc/buildout/buildout.py", line 1204, in _call
    return f()
  File "/srv/plone/levitunturi/hotellilevitunturi/eggs/plone.recipe.unifiedinstaller-4.3.1-py2.4.egg/plone/recipe/unifiedinstaller/__init__.py", line 63, in install
    client_ports = [
UnboundLocalError: local variable 'clients' referenced before assignment
*********************************************

If you have old BO like

[unifiedinstaller]
# This recipe installs the plonectl script and a few other convenience items.
# For options see http://pypi.python.org/pypi/plone.recipe.unifiedinstaller
recipe = plone.recipe.unifiedinstaller
user = ${client1:user}
primary-port = ${client1:http-address}
sudo-command = sudo
clients = client1 client2 client3

The workaround is to remove clients = line which is apparently not needed anymore

I tried to poke the code, but I am not sure what's the "right" fix.

[miohtama]

Also this is bad, because this breaks old 3.3.x buildouts which apparently originally did not pin down unifiedinstaller version.

[danmur]

It looks like clients doesn't get set if self._clients is populated, rather than populating clients based on self._clients

[smcmahon]

Thanks! Fixed for v. 4.3.2 (of plone.recipe.unifiedinstaller)