Change login endpoint to use username instead of login.

[tisto]

I just ran into this when debugging the login. The "@login" endpoint uses "login" instead of "username". Since Plone itself uses "username", I was confused at first.

@buchi can you elaborate why we use "login"/"password" instead of "username"/"password"?

[buchi]

@tisto "login" is the term used in PluggableAuthService. Unfortunately the naming is not very consistent in Plone.

I've not objections against renaming it to "username".

[tisto]

@buchi ok, then I would like to change that. We can still accept "login" to keep backwards compatibility. At least until we do a 1.0 release.

[jaroel]

We were discussion this in plone.api too, but the other way around. Currently that path is dead in the water, and I think we are not going to go down that road.

See plone/plone.api#270 and plone/plone.api#204 (comment) .

[jaroel]

btw, does login or username also work for login using email?