-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK / Library for Angular 2 #200
Comments
We do not want to start directly with a super layered architecture with dozens of packages.
The resourceapi-angular package will only focus on wrapping the REST API calls dedicated to pure content management.
This package might be splitted later on smaller pieces. |
Regarding documentation, we will use Markdown as it is the standard for JS packages. Note: there is a markdown renderer for Sphinx, so it should work for docs.plone.org. @svx do you have any opinion on that? |
Keep in mind that the markdown support for sphinx is limited, because Commonmark doesn’t support a lot of the concepts that RST lets you represent. There is no standardized way in Commonmark to represent Further, that also would mean, I have to write new and adjust current tests in order to use them against markdown, this is possible but will take some time. What is the long term plan ? Should these docs be included into docs.plone.org at some point ? We do not want to confuse user who want to contribute to docs, right ? :) Including them into our current build process is another issue, but this will hopefully solved with the currently work in process new test/build/and hosting setup. |
@svx I know rst is much more powerful than md. What's for sure is we need at least an |
@ebrehault are we talking about 'just' the README or about the docs in /docs, too ? |
@svx about the entire docs in /docs (I just wanted to highlight the only technical constraint we have is |
OK. If that is the only thing, meaning md is required for the README, what is with write the README in markdown and the docs in reST ? Pro:
Con:
That is btw, how I do it for some npm packages, for me this approach works, but that does not say it will work for you :). |
I will be more than happy to update our style-guide with a couple of lines and an example to explain that if you publish this package to npm, use markdown for your README. :) Just tell me for which version 5.1 ? 6 ? |
👍 for README in MD, long docs in ReST Including a local Sphinx-setup with recommnmark (https://github.com/rtfd/recommonmark) Sphinx-source-extension to allow including README.md into full docs would be nice. To show others that MD and ReST don't need to be mutually exclusive, but ReST is better for anything more than a page. |
@datakurre fine, fine ! :) What would be the benefit of including the README into /docs ? With/In a README you deliver 'only' certain information in a short version, like a very short summary on a book cover, where you link to deeper info which will be in /docs. |
@svx Agreed. Then its even easier. Probably I was just looking for an excuse to try that Sphinx markdown reader. |
@datakurre :) |
Implementation is here: https://github.com/plone/plone.restapi-angular |
@ebrehault Would it be possible to rewrite the README to follow https://docs.plone.org/about/documentation_styleguide.html#readme-example ? |
done |
Thanks !!!!!! |
A few issues need to be discussed before we can start:
The text was updated successfully, but these errors were encountered: