Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all plone.autoform tagged values #213

Closed
tisto opened this issue Feb 27, 2017 · 2 comments
Closed

Add support for all plone.autoform tagged values #213

tisto opened this issue Feb 27, 2017 · 2 comments

Comments

@tisto
Copy link
Sponsor Member

tisto commented Feb 27, 2017

This is a follow up of #198. We should support all tagged values that are defined in plone.autoform:

MODES_KEY = u"plone.autoform.modes"
OMITTED_KEY = u"plone.autoform.omitted"
ORDER_KEY = u"plone.autoform.order"
WIDGETS_KEY = u"plone.autoform.widgets"

READ_PERMISSIONS_KEY = u"plone.autoform.security.read-permissions"
WRITE_PERMISSIONS_KEY = u"plone.autoform.security.write-permissions"

https://github.com/plone/plone.autoform/blob/master/plone/autoform/interfaces.py#L13

@tisto tisto added this to the BeethovenSprint2017 milestone Feb 27, 2017
@tisto tisto mentioned this issue Feb 27, 2017
56 tasks
@lukasgraf lukasgraf self-assigned this Mar 4, 2017
@lukasgraf
Copy link
Member

I took this up at the Beethoven Sprint, and while for certain plone.autoform directives (omitted, mode, permissions) it's as simple as just exposing the tagged values (assuming IRO has been properly honoured), that's not the case for fieldset and field_order directives.

Those require some advanced interpretation in order to achieve a meaningful result. I therefore overhauled the way that the JSON schemas are built in the @types endpoint, see #237

@tisto
Copy link
Sponsor Member Author

tisto commented Mar 10, 2017

Merged in #237

@tisto tisto closed this as completed Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants