Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRichTextValue serializer uses value.output instead of value.output_relative_to #424

Closed
jaroel opened this issue Nov 7, 2017 · 2 comments

Comments

@jaroel
Copy link
Member

jaroel commented Nov 7, 2017

See https://github.com/plone/plone.restapi/blob/master/src/plone/restapi/serializer/converters.py#L139

Also see plone/plone.app.textfield#24

@jaroel jaroel changed the title IRichTextValue uses value.output instead of value.output_relative_to IRichTextValue serializer uses value.output instead of value.output_relative_to Nov 7, 2017
@tisto
Copy link
Sponsor Member

tisto commented Nov 7, 2017

@jaroel that sounds like a possible breaking change that we have to fix before moving into the beta stage. What do you think?

@tisto tisto added this to the 1.0b1 milestone Nov 7, 2017
@jaroel
Copy link
Member Author

jaroel commented Nov 7, 2017

@tisto It might break stuff that, on a non-root context, depends on .output being rendered using the site root.
I cannot imagine something like that, unless someone used a ITransform that only works with ISiteRoot.

I'm not against fixing this before moving to beta. That's what alphas are for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants